Use login.gov shared Stylelint configuration #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related: 18F/identity-idp#5689 **Why:** So that we can use a common standard ruleset across all repositories where Sass is used.
aduth
commented
Dec 9, 2021
| @@ -9,7 +9,7 @@ const replace = require('gulp-replace'); | |||
| const rename = require('gulp-rename'); | |||
| const gulpif = require('gulp-if'); | |||
| const sass = require('gulp-sass')(require('sass')); | |||
| const gulpStylelint = require('gulp-stylelint'); | |||
There was a problem hiding this comment.
gulp-stylelint may be abandoned, as it doesn't support the newest major release of Stylelint released early in the year, and the maintainer hasn't been active in related issues (olegskl/gulp-stylelint#132).
In any case, the dependency shifting here removed a lot from the dependency tree (net -1719 lines in package-lock.json), which I'm pretty happy about.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: 18F/identity-idp#5689
Why: So that we can use a common standard ruleset across all repositories where Sass is used.