LG-11714 update letter on the way screen #10335
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
reviewed
Mar 28, 2024
jmax-gsa
force-pushed
the
jmax/LG-11714-update-letter-on-the-way-screen
branch
from
9524568
to
bf508d4
Compare
Changelog: User facing improvements,GPO verify,Improved letter enqueued language
Co-authored by: Andrew Duthie <andrew.duthie@gsa.gov>
jmax-gsa
force-pushed
the
jmax/LG-11714-update-letter-on-the-way-screen
branch
from
6dd35a1
to
8f2fedf
Compare
aduth
reviewed
Apr 3, 2024
Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com>
Pass in `url_options` to constructor.
matthinz
reviewed
Apr 10, 2024
Pulled PII spelunking code out to a method.
Extracted method `Idv::Session#pii_from_user`
changelog: user-facing improvements,biometrics,improved "letter enqueued" screen language.
matthinz
reviewed
Apr 11, 2024
Removed Idv::Session#pii_from_user and cleaned up specs for #address_lines
Renamed `has_pii_from_user_in_flow_session` to `has_pii_from_user_in_flow_session?` and extracted `pii_from_user_in_flow_session`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帿 Ticket
Link to the relevant ticket:
LG-11714
馃洜 Summary of changes
Updated the "Your letter is on your way" page, per UX design.
馃摐 Testing Plan
The review app is available for testing here
n.b. - Because the review app does not have a sample SP available, the button text is 'Continue' rather than 'Exit Login.gov' in the review app. I can pair to demonstrate that the correct text appears when entering from an SP, or we can double-check the staging environment after this is merged. I suggest both.
馃憖 Screenshots
If relevant, include a screenshot or screen capture of the changes.
Entered from SP (English):
Entered from SP (Spanish):
Entered from SP (French):
These screenshots are not part of the production flow; they can only occur if one manually enters IdV, not if one enters from a service provider.
Manually Entered (English):
Manually Entered (Spanish):
Manually Entered (French):