Collapse simplified simple_form_for to single line #10610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changelog: Internal, Code Quality, Improve readability of view form code
mitchellhenke
approved these changes
May 13, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃洜 Summary of changes
Updates form markup to collapse rendering of
simple_form_forto a single line.This is a follow-up to #10604. I had originally planned to include these changes as part of that pull request, but decided against it in order to keep the diff simpler. But the simplifications enabled by that work remove a lot of configuration from
simple_form_forto allow many of them to reasonably fit within a single line of 100 column length or fewer.馃摐 Testing Plan
These changes are formatting-only, so not expected to have an impact on end-user experience.