Update to Ruby 3.3.1 #10627
Merged
Update to Ruby 3.3.1 #10627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchellhenke
force-pushed
the
mitchellhenke/ruby-3.3.1
branch
2 times, most recently
from
45250cf
to
1df408a
Compare
zachmargolis
approved these changes
May 14, 2024
mitchellhenke
force-pushed
the
mitchellhenke/ruby-3.3.1
branch
5 times, most recently
from
dd657b6
to
c7adbcb
Compare
zachmargolis
approved these changes
May 20, 2024
mitchellhenke
force-pushed
the
mitchellhenke/ruby-3.3.1
branch
from
6772319
to
b8723cc
Compare
Comment on lines
5
to
9
| # Wait for the the loading interstitial to disappear before continuing | ||
| expect(page).not_to have_content(t('doc_auth.headings.interstitial'), wait: 10) | ||
|
|
||
| begin | ||
| expect(page).not_to have_content(t('doc_auth.headings.interstitial'), wait: 10) | ||
| rescue Selenium::WebDriver::Error::StaleElementReferenceError |
There was a problem hiding this comment.
seeing all this repeated, I feel like we could probably build a helper like
wait_for_content_to_disappear do |page|
expect(page).not_to have_content(t('doc_auth.headings.interstitial'), wait: 10)
endand then that helper method has these rescue blocks built in
There was a problem hiding this comment.
Good call, added in d8d45bf
changelog: Internal, Maintenance, Update to Ruby 3.3.1
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
mitchellhenke
force-pushed
the
mitchellhenke/ruby-3.3.1
branch
from
b8723cc
to
d8d45bf
Compare
zachmargolis
approved these changes
May 23, 2024
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
mitchellhenke
added a commit
that referenced
this pull request
May 28, 2024
This reverts commit fb74d7b.
mitchellhenke
added a commit
that referenced
this pull request
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃洜 Summary of changes
Follows #10609 to upgrade CI to run 3.3.1 and updates the repo to use 3.3.1 along with it