Ложное срабатывание проверки типа #1048 #1416
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marmyshev
requested changes
Mar 4, 2024
Comment on lines
+107
to
+108
| || IBslCommentToken.TYPE_SECTION_DASH.equals(text.trim()) && lastLine != part.getLineNumber()) | ||
| || text != null && text.startsWith("@skip-check")) //$NON-NLS-1$ |
There was a problem hiding this comment.
Здесь проблеме не в проверке а в том, поддерживает ли модель данных док.коммента и расчет типов ЕДТ по модели поддерживает такую ситуацию? тип по ссылке считается корректно, если есть TextPart после ссылки?
There was a problem hiding this comment.
Модель не поддерживает расчет типа по ссылке, так что видимо не ложное срабатывание
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Что сделано
Чек-лист
Общее:
masterи нет конфликтовЕсли применимо:
Закрываемые задачи
Closes 1C-Company/1c-edt-issues#1048