[BUG]: Gifts shifting in time

[mbiesiad]

Describe the bug

Looks like the Gifts are shifting in time (Calendar view). One day next.

To Reproduce

Go to the Dashboard (logged in).
Fill the fields for manual contribution's record (add for single day, more than one contribution).
See that one of the contribution is shifed to the next day.

In my case, at this moment I can see the contribution for tomorrow, but I'm pretty sure that the last day typed by me was today.

Best wishes,
Michal

Expected Behavior

Contribution is not shifed to the next day on the Calendar view (works correct).

Screenshot/ Video

Screenshot attached:

Today is 3rd of Dec., but we can see the 4th of Dec there.

Additional context

I will check it again / deep into it, and let know now ASAP.

Quick update - confirmed. Still exist (today I can see marked for tomorrow again).

[emclaughlin1215]

This one is a question of how y'all want the gift calendar to work. Currently it populates one PR per day, it looks like, no matter which day the PR actually occurred. That's why they appear to be shifting: the date on the calendar has no relation to the date the PR was put in.

@andrew I'm assuming that this should be changed so the PR is shown on the correct date? Allowing multiple PRs per date?

[andrew]

So this one could end up being pretty involved with lots of changes, a bit of a rabbit hole as the whole "autogift" concept was added and changed a number of times over the years, currently it tries to fill up the calendar view with one contribution each day which can be confusing.

There's a few different ways we could make it work, I'm kinda tempted to throw out the calendar view all together and show more of a timeline view with contributions grouped by date in a list.

[ljharb]

What’s the point of “24 pull requests” if it’s not an advent calendar? 0, or 1+ contributions per day, and if you miss a day you miss one.

[mbiesiad]

In my opinion, the point is to celebrate these amazing days with the Open Source contributions. For me, the idea is similar like for 'Open Source Friday' (support and celebrate). By the way, I'm not sure, but if you have a "chocolate advent calendar", you can always take the missed one piece of chocolate :P

[ljharb]

in that case why do the PRs need to be in December at all? Why not grab any pull requests from November, or the entire year?

[mbiesiad]

From my point of view, because it's about designated holiday days (you can see that in calendar view, 1-25th Dec). Such as Friday in 'Open Source Fri.'

[ljharb]

Right - but if it’s about designated days, then the contributions should have to happen on those days too.

The point of an advent calendar is to think about Christmas each day until Christmas - if you skip a day then that day was simply skipped.

[emclaughlin1215]

So, I'm looking at this one again. After skimming the code, it looks like the steps are basically:

1. Make sure the gift date set to the contribution date instead of whatever date is up next
2. Update views displaying calendars to show events on those dates, not just one after another
3. Tests :(
4. Update past gifts to reflect their contribution dates instead of what they're set to now???

Does that look accurate or are there places that gift dates are used that I'm missing?