New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix eslint 'react/no-object-type-as-default-prop' #3364

Closed

mayorova wants to merge 2 commits into master from fix-eslint-object-type-default-prop

Contributor

mayorova commented May 16, 2023

What this PR does / why we need it:

Fixing:

XXX has a/an array literal as default prop. This could lead to potential infinite render loop in React. Use a variable reference instead of array literal  react/no-object-type-as-default-prop

For some reason started appearing in #3363

Which issue(s) this PR fixes

-none-

Verification steps

run yarn ci:lint

Special notes for your reviewer:


          Fix eslint 'react/no-object-type-as-default-prop'

6d128ea

Contributor Author

mayorova commented May 16, 2023

ATM, https://github.com/3scale/porta/blob/fix-eslint-object-type-default-prop/app/javascript/src/Common/components/TableModal.tsx#L65 is pending to be fixed still.


          Add an exception for react/no-object-type-as-default-prop

2ab73ee

Contributor Author

mayorova commented May 17, 2023

Closing, as the changes will be incorporated into #3363

mayorova closed this

mayorova deleted the fix-eslint-object-type-default-prop branch

July 11, 2023 14:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment