馃 Update webhook edit page #3785
Conversation
josemigallas
force-pushed
the
THREESCALE-10268_webhook_edit
branch
4 times, most recently
from
33ccc08
to
657ddba
Compare
| hidden_field_html + input + label + description | ||
| end | ||
|
|
||
| return checkbox if options[:nude] |
There was a problem hiding this comment.
Hmm... is that needed? I don't notice any changes if I drop this.
There was a problem hiding this comment.
I makes the resulting HTML exactly like Patternfly 4, but like you say, it doesn't affect either the layout or the tests so I will remove it.
| div class="pf-c-form__section-title" aria-hidden="true" Webhooks endpoint | ||
| div class="pf-c-form__group" | ||
| - show_action = @webhook.persisted? && @webhook.url.present? | ||
| = form.input :url, as: :patternfly_input, action:(show_action ? { title: 'Ping!', 'data-ping-url': provider_admin_webhooks_path } : nil) |
There was a problem hiding this comment.
It's kinda weird, that you need to actually enable webhooks, and set the URL, and save the form, and only then the Ping button will appear. But that was the previous behavior also, so it's fine.
| Given they go to the new webhook page | ||
| And there shouldn't be a button to "Ping!" | ||
| When the form is submitted with: | ||
| | URL | http://google.com | |
There was a problem hiding this comment.
I don't get why we are using google.com in our examples 馃檭 maybe it needs to be changed to something more redhatt-y or 3scale-ey
but this was like this before, so... OK.
There was a problem hiding this comment.
Ah, yes! In fact I meant to change it, but cucumbers sucked all my energy and I forgot. I will do it asap.
josemigallas
force-pushed
the
THREESCALE-10268_webhook_edit
branch
from
27e4619
to
28c5cbf
Compare
THREESCALE-10268: Account Settings > Integrate > Webhooks
Before:
After:
