fix: modal-open class remains on body after modal closed #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gidomanders
force-pushed
the
fix/modal-not-closing-properly
branch
from
d91cb52
to
4ebfe2e
Compare
MrHus
approved these changes
Jun 22, 2020
Codecov Report
@@ Coverage Diff @@
## master #437 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 99 99
Lines 2031 2035 +4
Branches 468 468
=========================================
+ Hits 2031 2035 +4
Continue to review full report at Codecov.
|
The modal-open class remains on the body tag even after the modal is closed. This is an issue of the reactstrap library (reactstrap/reactstrap#1323) which is already fixed buy not released yet. Added a temporary work-around to remove the modal-open class when modal is closed. Closes #426
gidomanders
force-pushed
the
fix/modal-not-closing-properly
branch
from
4ebfe2e
to
e6a7e2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The modal-open class remains on the body tag even after the modal is
closed. This is an issue of the reactstrap library
(reactstrap/reactstrap#1323) which is already
fixed buy not released yet.
Added a temporary work-around to remove the modal-open class when modal
is closed.
Closes #426