improvement: HTML attributes on Input #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gidomanders
force-pushed
the
improvement/autocomplete-attribute-on-input
branch
from
1ce6999
to
e928573
Compare
I want to set autocomplete on an input, but that's not an allowed property of Input yet. Added support for HTML attributes on Input element.
gidomanders
force-pushed
the
improvement/autocomplete-attribute-on-input
branch
from
e928573
to
3847dad
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #707 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 131 131
Lines 2783 2786 +3
Branches 824 824
=========================================
+ Hits 2783 2786 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to set autocomplete on an input, but that's not an allowed property of Input yet.
Added support for HTML attributes on Input element.