-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discord: Split messages if necessary #2124
Conversation
aa247d2
to
a91a14c
Compare
Changes since last push: Refactored |
Code Climate has analyzed commit a91a14c and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
@BenWiederhake thanks for looking into this and adding tests 👍 |
Awesome! It's good that you're back, I already got worried :) |
Hmm, I can edit neither of the wikis, and I don't see an invitation notification. :( |
I deleted and readded the invitation, it also says: "They can also visit https://github.com/matterbridge to accept the invitation." |
Old behavior: Telegram user sends a huge 4096-byte message (the maximum permitted by Telegram), it gets clipped to 1950 bytes on Discord.
New havior: Set
MessageSplitMaxCount=3
as config option of the Bridge, and it instead sends up to three messages to Discord (each of maximum length)Note that this handles editing correctly, both in the "bot user" and "webhooks" cases.
This PR combines well with #2123.
I have no write permissions to the wiki, so I cannot add the appropriate documentation there.