fix(no-this-assign-in-render): explicit left hand side traversal #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The esquery we were using was too wide in that it would match a `.left`
at _any_ level.
This meant the following code would match:
```ts
render() {
x = this.foo || 123;
}
```
As a `LogicalExpression` has a left just like an `AssignmentExpression`.
Since esquery doesn't support relative direct child selection (i.e.
using `:has(> foo)`), we are now selecting the left side node and
reporting on the parent instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The esquery we were using was too wide in that it would match a
.leftat any level.This meant the following code would match:
As a
LogicalExpressionhas a left just like anAssignmentExpression.Since esquery doesn't support relative direct child selection (i.e. using
:has(> foo)), we are now selecting the left side node and reporting on the parent instead.