Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (bindInput): remove listeners from old element #16

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

43081j
Copy link
Owner

@43081j 43081j commented Apr 13, 2023

good catch by @tbroyer

basically remove the listeners from the previous element rather than the current one

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4693432069

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.236%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/directives/bindInput.ts 0 1 0.0%
Totals Coverage Status
Change from base Build 4420305954: 0.0%
Covered Lines: 2100
Relevant Lines: 2121

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4693432069

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.236%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/directives/bindInput.ts 0 1 0.0%
Totals Coverage Status
Change from base Build 4420305954: 0.0%
Covered Lines: 2100
Relevant Lines: 2121

💛 - Coveralls

@43081j 43081j merged commit 2f0a145 into main Apr 13, 2023
2 checks passed
@43081j 43081j deleted the bind-input-listeners branch April 13, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants