fix: clean up some of the new rules (#707)

4Catalyzer · Dec 12, 2021 · 5426510 · 5426510
1 parent 32e16ca
commit 5426510
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/packages/eslint-config-4catalyzer-react/rules.js b/packages/eslint-config-4catalyzer-react/rules.js
@@ -12,6 +12,12 @@ module.exports = {
     },
   ],
 
+  // We don't care which kind of function you use
+  'react/function-component-definition': 'off',
+
+  // This is useful in places like Typescript where string does not satisfy the expected return type of JSX.Element. A common workaround is to wrap the variable holding a string in a fragment and expression.
+  'react/jsx-no-useless-fragment': ['error', { allowExpressions: true }],
+
   // this rule is dumb
   'react/jsx-no-bind': 'off',
 

diff --git a/packages/eslint-config-4catalyzer/rules.js b/packages/eslint-config-4catalyzer/rules.js
@@ -3,6 +3,7 @@ module.exports = {
   'arrow-body-style': 'off',
   'prefer-arrow-callback': 'off',
   'class-methods-use-this': 'off',
+  'no-promise-executor-return': 'off',
   'max-len': [
     'error',
     79,