Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update rules for new TS recommended #623

Merged
merged 2 commits into from May 22, 2020
Merged

fix: Update rules for new TS recommended #623

merged 2 commits into from May 22, 2020

Conversation

itajaja
Copy link
Member

@itajaja itajaja commented May 22, 2020

it's on by default with ts eslint 3.0. wdygt?

it's on by default with ts eslint 3.0. wdygt?
@itajaja itajaja requested review from taion and jquense May 22, 2020 14:29
@taion
Copy link
Contributor

taion commented May 22, 2020

ref typescript-eslint/typescript-eslint#1423

we should remove the override for explicit-function-return-type, as that's no longer present (and that was what "broke")

we need to change ban-ts-ignore to ban-ts-comment

i wish we could make this check just for "arg type defs present", though. that would be useful; we often forget to do : Props. i guess no-implicit-any covers that, though.

@taion taion changed the title disable ts explicit-module-boundary-types fix: Update rules for new TS recommended May 22, 2020
@taion taion merged commit 015d1e5 into master May 22, 2020
@taion taion deleted the itajaja-patch-1 branch May 22, 2020 19:08
@itajaja
Copy link
Member Author

itajaja commented May 22, 2020

i guess no-implicit-any covers that, though.

right, that was my thinking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants