Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add read directory to filesystem extension #6191

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

arthuro555
Copy link
Contributor

Adds an action to read a directory to the filesystem actions.

@arthuro555 arthuro555 requested a review from 4ian as a code owner January 15, 2024 12:00
@arthuro555
Copy link
Contributor Author

(This should be ready for review)

@RebornOfc
Copy link

RebornOfc commented Jan 24, 2024

Thats great, but what if instead of reading every sub-directory at once, the user can insert a depth limit?

-1 = everything
0 = only the main level
1 = only the main level and its sub-directories
2 = (...)

@Cheapetsgrow
Copy link

Two passed with flying colors

@arthuro555
Copy link
Contributor Author

Thats great, but what if instead of reading every sub-directory at once, the user can insert a depth limit?

The implementation is not recursive, it should only read the contents of the directory, not sub directories. A recursive read can be done through a loop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants