-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a warning on linked external events from another scene #6563
Conversation
newIDE/app/src/EventsSheet/EventsTree/Renderers/LinkEvent/index.js
Outdated
Show resolved
Hide resolved
{this.isLinkedToWrongLayout(target) ? ( | ||
<span | ||
className={classNames({ | ||
[instructionWarningParameter]: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be surely worth to create a new css class for this - this is not really a parameter and we can see the icon is too small compared to the text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a CSS rule for an icon in an event link. As the warning class only affect the color and underlining, I guess we could rename instruction-warning-parameter
to something like warning-parameter
one day.
newIDE/app/src/EventsSheet/EventsTree/Renderers/LinkEvent/index.js
Outdated
Show resolved
Hide resolved
I suggest we move this to a ℹ️ icon with "Ensure the scene has the same objects, behavior and variables as the one used in these events" as the copy. |
Changes