This repository has been archived by the owner on Dec 21, 2022. It is now read-only.
Feature/no param properties rule #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
June 19, 2017 15:29
indent rule does not yet allow setting a number of spaces. I made a note at the indent-rule reminding to use 4 spaces.
5ebastianMeier
suggested changes
Jun 26, 2017
tslint-config-5minds/README.md
Outdated
| 3.3 **indent:** Enforces indentation spaces. | ||
|
|
||
| 3.3 **indent:** Enforces indentation spaces. As soon as this rule supports setting the number of spaces per indentation it will be set to 4 spaces in the 5Minds-tslint-config. |
There was a problem hiding this comment.
da wir das noch diskutieren bitte diesen Absatz ändern - 4 spaces sind nur eine Möglichkeit
There was a problem hiding this comment.
2 Space, da der meiste JS-Code bereits 2 beinhaltet und TypeScript sich daran anlehnen.
moellenbeck
suggested changes
Jun 26, 2017
S3bastianGriesa
suggested changes
Jul 5, 2017
tslint-config-5minds/README.md
Outdated
| class Foo { | ||
|
|
||
| constructor(private bar: Bar) {} | ||
| } |
There was a problem hiding this comment.
Würde hier noch eine Leerzeile einfügen, damit es konsistent zum obigen // good Beispiel ist.
S3bastianGriesa
approved these changes
Jul 5, 2017
5ebastianMeier
approved these changes
Aug 4, 2017
|
Wie ist hier der Stand? Scheint ein wenig in Vergessenheit geraten zu sein :) |
|
Change requests wurden behandelt. Indent-size situation verbessert sich sobald wir tslint updaten und die richtige Regel nutzen (#12) (gehört aber nicht in diesen PR). |
Current version of our tslint includes new indent version which allows specifying number of spaces/tabs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verbietet folgenden Code: