Fix Regression When Adding Torrent Files #1351
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignore VSCode Dev Container files. Resolves 6c65726f79#1309, resolves 6c65726f79#1340
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point, the
parse-torrentdependency was upgraded; the new version of this dependency relies on another dependency nameduint8-utilwhich relies on the WebCrypto API for message digest functions.Unfortunately, the WebCrypto API is only available in secure contexts (HTTPS or localhost). This is likely why the regression was not caught sooner, because a developer would have to go out of their way to load the web app in an insecure context in order to experience the bug.
This PR reverts to the previous version of the offending dependency, which appears to solve the problems users are experiencing with adding torrent files from local filesystem or by URL.
Resolves #1309, resolves #1340.