fix: apollo federation tracer was race prone #2366
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The apollo federation tracer was using a global state that was accessed from different goroutines regardless of the request they are currently handling.
Added req headers to operation context to allow it to be fetched in InterceptOperation
When running the following test (via
go test -race ./...
) i was able to consistently get error messages from go's race detection.Made some additional fixes to the test so it passes with
-race
flag.