Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider goField directive for getters generation #2440

Closed
wants to merge 1 commit into from
Closed

consider goField directive for getters generation #2440

wants to merge 1 commit into from

Conversation

darkLord19
Copy link
Contributor

@darkLord19 darkLord19 commented Nov 28, 2022 •
edited by StevenACoffman

Fixes #2439

When you have an interface and override generated models fields name with goField directive. This PR makes it so getters generated by gqlgen will access field values using the field that was specified in the goField directive.

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 75.625% when pulling ac6ae2f on darkLord19:master into f28ffcc on 99designs:master.

@StevenACoffman StevenACoffman mentioned this pull request Dec 3, 2022
Merged
2 tasks
@StevenACoffman
Copy link
Collaborator

Closed in favor of reformatted #2447

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@97amarnathk 97amarnathk 97amarnathk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Interface getters are not using goField directive
4 participants
@darkLord19 @coveralls @StevenACoffman @97amarnathk