Addressing few issues in defer feature #2656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And fixed hasNext to only appear in the payload when there is deferred usage
|
Thanks for this! I would love more tests, but the websocket testing story is not obvious. We are also using the unmaintained github.com/gorilla/websocket instead of the https://pkg.go.dev/nhooyr.io/websocket |
|
I'll implement first set of tests using SSE if u don't mind |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed hasNext being omitted when false, now it would only appear in the payload when there is deferred usage.
Applied @fiatja atomic patch
Here is modified version of GraphiQL playground that works with SSE https://gist.github.com/UnAfraid/c2f9ed63332c47a2d588213fdbcfd688
I did some testing in real world environment and it seems to work as intended.
I'm looking into writing some tests, but that would require implementation of SSE in the client package first correct?