Make models configurable via template #2729
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penard-cb
force-pushed
the
ConfigurableModelsTemplate
branch
from
c071173
to
e1c49cf
Compare
|
I force pushed after rebasing. Should I not have done that? now some of the checks failed. Do I need to spin up a new PR? cc: @StevenACoffman thoughts? |
|
I'm just going to abandon this one in favor of #2730 which i didn't rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly as in #2720 and #2725 this PR makes the models configurable as well via template. This opens up a lot of new options for configuration and using the templating functionality
I have: