Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gqlgen truncates tag value with colon #2759

Merged
merged 1 commit into from Aug 25, 2023
Merged

Fix gqlgen truncates tag value with colon #2759

merged 1 commit into from Aug 25, 2023

Conversation

xzzpig
Copy link
Contributor

@xzzpig xzzpig commented Aug 16, 2023

Fix #2687 gqlgen truncates tag value with colon

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

@coveralls
Copy link

coveralls commented Aug 16, 2023 •
edited

Coverage Status

coverage: 75.738% (-0.04%) from 75.777% when pulling 7ea1af9 on xzzpig:master into d6270e4 on 99designs:master.

@aleybovich
Copy link
Contributor

I hope this change gets merged soon - it's blocking me as well, preventing from using gorm with gqlgen

@StevenACoffman StevenACoffman merged commit 065aea3 into 99designs:master Aug 25, 2023
18 checks passed
@aleybovich
Copy link
Contributor

@StevenACoffman thank you for merging this important fix. Do you have an ETA for the next release?

@emanuel-gjini
Copy link

@StevenACoffman Thank you for this fix. Is there an ETA for the next release as the lack of this fix is holding us back from updating ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gqlgen truncates tag value with :
5 participants
@xzzpig @coveralls @aleybovich @emanuel-gjini @StevenACoffman