Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure HasOperationContext checks for nil #2776

Merged
merged 1 commit into from Aug 29, 2023
Merged

ensure HasOperationContext checks for nil #2776

merged 1 commit into from Aug 29, 2023

Conversation

chriscerk
Copy link
Contributor

Describe your PR and link to any relevant issues.

resolves: #2775

Upon merging:

  • When calling HasOperationContext
    to check if there is a valid operation context,
    GetOperationContext will never panic when
    HasOperationContext returns true.

I have:

  • Added tests covering the bug / feature (see testing)
  • (N/A) Updated any relevant documentation (see docs)

@coveralls
Copy link

coveralls commented Aug 28, 2023 •
edited

Coverage Status

coverage: 75.791% (-3.6%) from 79.377% when pulling b9a47a2 on chriscerk:chriscerk/fix/2775-has-op-context into a1ca220 on 99designs:master.

@StevenACoffman StevenACoffman merged commit cc4e0ba into 99designs:master Aug 29, 2023
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HasOperationContext does not fully protect GetOperationContext
3 participants
@chriscerk @coveralls @StevenACoffman