Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restor the response object #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

yalishizhude
Copy link
Contributor

I'm strongly against to modify response object, for 2 reasons:

  1. It will conflict with a response object has the same property "status".
  2. It calls the mergeObjects function which forcely changes the response(maybe it's a string,array,number or sth else) to an object.That's really a bad thing!

@coveralls
Copy link

coveralls commented Jun 3, 2016

Coverage Status

Coverage decreased (-0.06%) to 97.561% when pulling 717789d on yalishizhude:master into 4c49a5e on A:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants