Merge pull request #32 from A11yance/fix-select-mapping

Fix mapping for the HTML select element
A11yance · Nov 26, 2019 · a5cf6b0 · a5cf6b0
2 parents 900cfd9 + 8cbdf1d
commit a5cf6b0
Show file tree

Hide file tree

Showing 19 changed files with 277 additions and 282 deletions.
diff --git a/flow/aria.js b/flow/aria.js
@@ -312,5 +312,8 @@ type ARIARoleRelationConcept = {
 
 type ARIARoleRelationConceptAttribute = {
   name: string,
-  value?: string,
+  value?: string | number,
+  // Make these explicit. These values represent quirks of the mapping betweent
+  // ARIA and other semantic ontological systems.
+  constraints?: Array<'unset' | '>1'>,
 };
diff --git a/scripts/breakUpAriaJSON.js b/scripts/breakUpAriaJSON.js
@@ -94,6 +94,9 @@ function triageValue(value, depth = 0) {
     case 'string':
       output = output.concat(`\'${value}\'`);
       break;
+    case 'number':
+      output = output.concat(`${value}`);
+      break;
     default:
       output.push('null');
   }
@@ -143,6 +146,9 @@ fs.readFile(path.join('scripts/roles.json'), {
       // Deprecate requireContextRole prop. Replace with requiredContextRole.
       // requireContextRole will be removed in a future version.
       aria[name]['requireContextRole'] = aria[name]['requiredContextRole'];
+      // Deprecate baseConcepts prop.
+      // baseConcepts will be removed in a future version.
+      aria[name]['baseConcepts'] = [];
 
       const file = [
         '/**',