Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove Symbol usage for older environments #27

Merged
merged 1 commit into from Nov 26, 2019

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Nov 1, 2019

Currently some of the syntax used results in transpiled code that assumes ES6 Symbol:
https://unpkg.com/aria-query@3.0.0/lib/elementRoleMap.js (see _slicedToArray)

This is currently an abandoned issue in babel  that is solvable by using @babel/plugin-transform-runtime with the corejs option. This will over transpile most of the features but I assumed that bundle size is of little concern for this package right now. The most popular dependents are generally dev dependencies (eslint-plugin-a11y and @testing-library/dom). Over transpiling should be fixed once babel/babel#10008 is done.

To avoid digging through older documentation I just went ahead and upgrade babel to the latest version (which subsequently required a jest bump).

@jessebeach
Copy link
Member

I hadn't considered that this would be used in-browser. I'll need to merge the changes manually. I don't see a reason not to accommodate this case.

@jessebeach jessebeach mentioned this pull request Nov 26, 2019
@jessebeach jessebeach merged commit 1112cf9 into A11yance:master Nov 26, 2019
@eps1lon eps1lon deleted the fix/ie11 branch November 26, 2019 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants