fix: Remove Symbol usage for older environments #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently some of the syntax used results in transpiled code that assumes ES6 Symbol:
https://unpkg.com/aria-query@3.0.0/lib/elementRoleMap.js (see
_slicedToArray
)This is currently an abandoned issue in babel that is solvable by using
@babel/plugin-transform-runtime
with thecorejs
option. This will over transpile most of the features but I assumed that bundle size is of little concern for this package right now. The most popular dependents are generally dev dependencies (eslint-plugin-a11y
and@testing-library/dom
). Over transpiling should be fixed once babel/babel#10008 is done.To avoid digging through older documentation I just went ahead and upgrade babel to the latest version (which subsequently required a jest bump).