Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update element role mappings #550

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jlp-craigmorten
Copy link
Contributor

@jlp-craigmorten jlp-craigmorten commented Apr 1, 2024

Resolves #553

The mappings for hgroup, s, and search elements are missing or are incorrect/outdated.

This updates as so:

  • hgroup element is now associated with the group role and no longer associated with the generic role.
  • s element is now associated with the deletion role.
  • search element is now associated with the search role.

Relevant specs:

See also Web Platform Tests for HTML-AAM roles.

Copy link

codesandbox-ci bot commented Apr 1, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8508801368

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.455%

Totals Coverage Status
Change from base Build 5366160847: 0.0%
Covered Lines: 248
Relevant Lines: 253

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect element role mappings
2 participants