Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): [DEVOPS-1759] update to latest aws sdk #245

Merged
merged 1 commit into from Jun 29, 2023

Conversation

scub
Copy link
Contributor

@scub scub commented Jun 29, 2023

What did you implement:

Updates to the latest SDK to ensure xml2js version on consumers is up to date

How did you implement it:

How can we verify it:

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Provide verification config/commands/resources

Copy link

@la-roberto la-roberto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Updating the aws-sdk so that it can force update xml2js.
  • After running yarn install, I can confirm that xml2js is where we need it to be at v0.5.0:
[5/5] 🔨  Building fresh packages...
$ husky install
husky - Git hooks installed
✨  Done in 5.12s.
$ yarn why xml2js
yarn why v1.22.19
[1/4] 🤔  Why do we have the module "xml2js"...?
[2/4] 🚚  Initialising dependency graph...
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found "xml2js@0.5.0"
info Reasons this module exists
   - "aws-sdk" depends on it
   - Hoisted from "aws-sdk#xml2js"
info Disk size without dependencies: "148KB"
info Disk size with unique dependencies: "512KB"
info Disk size with transitive dependencies: "512KB"
info Number of shared dependencies: 2
✨  Done in 0.43s.

@scub scub merged commit 6efcbc0 into master Jun 29, 2023
4 checks passed
@scub scub deleted the DEVOPS-1759-xmljs-vers branch June 29, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants