Throw original exception if debug is enabled.

ADmad · Mar 4, 2021 · dfa4a82 · dfa4a82
1 parent 1102f8f
commit dfa4a82
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/src/Middleware/GlideMiddleware.php b/src/Middleware/GlideMiddleware.php
@@ -6,6 +6,7 @@
 use ADmad\Glide\Exception\ResponseException;
 use ADmad\Glide\Exception\SignatureException;
 use ADmad\Glide\Response\PsrResponseFactory;
+use Cake\Core\Configure;
 use Cake\Core\InstanceConfigTrait;
 use Cake\Event\EventDispatcherInterface;
 use Cake\Event\EventDispatcherTrait;
@@ -342,6 +343,10 @@ protected function _handleException(ServerRequestInterface $request, $exception)
             return $result;
         }
 
+        if (Configure::read('debug')) {
+            throw $exception;
+        }
+
         throw new ResponseException(null, null, $exception);
     }
 }
diff --git a/tests/TestCase/Middleware/GlideMiddlewareTest.php b/tests/TestCase/Middleware/GlideMiddlewareTest.php
@@ -6,11 +6,13 @@
 use ADmad\Glide\Exception\ResponseException;
 use ADmad\Glide\Exception\SignatureException;
 use ADmad\Glide\Middleware\GlideMiddleware;
+use Cake\Core\Configure;
 use Cake\Event\EventManager;
 use Cake\Http\Response;
 use Cake\Http\ServerRequestFactory;
 use Cake\TestSuite\TestCase;
 use Cake\Utility\Security;
+use League\Flysystem\UnableToRetrieveMetadata;
 use League\Glide\ServerFactory;
 use League\Glide\Signatures\Signature;
 use TestApp\Http\TestRequestHandler;
@@ -180,15 +182,28 @@ public function testSignatureException()
         $middleware->process($request, $this->handler);
     }
 
+    public function test3rdPartyException()
+    {
+        $middleware = new GlideMiddleware($this->config);
+        $request = ServerRequestFactory::fromGlobals([
+            'REQUEST_URI' => '/images/non-existent.jpg',
+        ]);
+
+        $this->expectException(UnableToRetrieveMetadata::class);
+        $middleware->process($request, $this->handler);
+    }
+
     public function testResponseException()
     {
         $middleware = new GlideMiddleware($this->config);
         $request = ServerRequestFactory::fromGlobals([
             'REQUEST_URI' => '/images/non-existent.jpg',
         ]);
 
+        Configure::write('debug', false);
         $this->expectException(ResponseException::class);
         $middleware->process($request, $this->handler);
+        Configure::write('debug', true);
     }
 
     public function testExceptionEventListener()