Icu language support #320
Open
Icu language support #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cruddl has an optimization for case-insensitive equals and starts-with filters. This optimization depends on the collator that defines the ordering of strings. The previous code only supported --default-language=en_US. --default-language is deprecated in favor of --icu-language. This commit adds support for --icu-language=en_US. We currently cannot test for this in the CI pipeline because it is not possbile to use --icu-language in the official Docker image.
|
After clarifying with the ArangoDB support, we learned that the 'default'-typed languages will not be removed anytime soon, so it is not necessary to migrate. It probably still makes sense to support it in cruddl, but I would provide an option to enable or disable it, as it will make the queries more complex (MIN/MAX with UPPER+LOWER instead of just UPPER/LOWER). To test it, we need to put a copy of the arangodb.conf file in the container |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: support --icu-language=en_US ArangoDB configuration
cruddl has an optimization for case-insensitive equals and starts-with filters. This optimization
depends on the collator that defines the ordering of strings. The previous code only supported
--default-language=en_US. --default-language is deprecated in favor of --icu-language.
This commit adds support for --icu-language=en_US.
We currently cannot test for this in the CI pipeline because it is not possbile to use --icu-language
in the official Docker image.