QOL Items - handle metadata issues more cleanly for SD models, Loras and embeddings #15632
+28
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n them I have encountered pickled embeddings with a short byteorder file at the top-level, as well as a .data/serialization_id file. Both load fine after allowing these files in the dataset. I do not think it is likely adding them to the safe unpickle regular expression would be a security risk, but that's for the maintainers to decide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a diverse set of metadata content formatting out in the wild. When sd-webui scans all of the models at startup, sometimes it does not handle encountering unexpected metadata well. These minor changes may reduce console spam and may possibly allow more models to be loaded.
e.g. there is a small fix to the safe unpickle regular expression to allow for two additional files in the zipfile that I have encountered in several embeddings. I point that out so that the additional safety review is performed.
Additional analysis of some additional problematic files, and perhaps an additional PR to follow.
100% willing to make adjustments/resubmit as requested by maintainers. I will handle rejection well.
Checklist:
All tests passed. Some deprecation warnings were generated in the face_restorers tests.