remove 'replace' directive #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I removed the critical CVEs, but there is still one minor CVE with the old miekg module.
The problem is that `go install` won't work if I use `exclude` or `replace` directive.
Error looks like:
```
The go.mod file for the module providing named packages contains one or
more replace directives. It must not contain directives that would cause
it to be interpreted differently than if it were the main module.
```
Signed-off-by: kuritka <kuritka@gmail.com>
|
Regarding Cobra RELEASE Now using Viper v1.10.0 The Miekg CVE will be fixed with upcomming Cobra release. |
|
@kuritka why do we need dns package in golic? |
|
@ytsarev.The DNS package is included in Viper package which is included in Cobra. That's why CVE occurs. GoLic doesn't work at all with DNS or Viper, on the other hand we use COBRa. The problem is I can't use |
|
@kuritka got it, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the critical CVEs, but there is still one minor CVE with the old miekg module. The problem is that
go installwon't work if I useexcludeorreplacedirective.see: golang/go#40276
I briefly tested this against k8gb and working as expected
Signed-off-by: kuritka kuritka@gmail.com