Use autotools for PCRE2.cmake (Windows Only) #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
cedrik-fuoco-adsk
requested review from
bernie-laberge,
rogernelson and
geffrak
as code owners
geffrak
approved these changes
May 17, 2024
bernie-laberge
approved these changes
May 21, 2024
cedrik-fuoco-adsk
merged commit bbd2c3f
into
AcademySoftwareFoundation:main
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use autotools for PCRE2.cmake (Windows Only)
Linked issues
#462
Summarize your change.
Changing back to autotools instead of CMake for PCRE2.
Describe the reason for the change.
A few weeks ago, I changed the build for PCRE2 to use CMake instead of autotools, but it seems like it is causing some issue on some Windows setups from the community.
This is the same code as before the changes to CMake.
Describe what you have tested and on which operating system.
Windows
Add a list of changes, and note any that might need special attention during the review.
If possible, provide screenshots.