Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Windows Key Store Access #820

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

csottile
Copy link

The changes contained in the commit allow, through appropriate configurations, to be able to access the Windows Key Stores through the use of the SunMSCAPI.
This access is allowed only if the software is installed on a Windows OS machine.

Into deployment.properties
"deployment.security.use.rootca.store.type.windowsRoot=true" --> Allow to access Windows-ROOT Key Store
"deployment.security.use.rootca.store.type.windowsMy=true" --> Allow to access Windows-My KeyStore

itw-settings-certificates

The changes contained in the commit allow, through appropriate configurations, to be able to access the Windows Key Stores through the use of the SunMSCAPI.
This access is allowed only if the software is installed on a Windows OS machine.
@janakmulani
Copy link
Contributor

Can you please fix the following test:
Failures: Error: KeyStoresTest.getKeyStoreWindowsRootTestSM:139 expected:<JKS> but was:<WINDOWS>

Test needs to check preconditions. Windows Store may be accessible.
@csottile
Copy link
Author

KeyStoresTest.java Fixed.
Preconditions have been set for test execution.

thx

@csottile
Copy link
Author

Hi all,
I released the fix but some tests fail.

Does it depend on the released software? Can someone help me?

Thx

@csottile csottile closed this Dec 22, 2021
@csottile csottile reopened this Dec 22, 2021
@csottile
Copy link
Author

Hi all,

I renew request for help. Can anyone?

Thx

@csottile
Copy link
Author

Hi all,

I see all checks are passed. Can you let me know if, and when, the PR will be accepted and merged on the main branch?

Looking forward to your feedback.

Thank you,
Carmelo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants