Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add deprecation notice to casks #540

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add deprecation notice to casks #540

wants to merge 2 commits into from
+371 −27

Conversation

gdams
Copy link
Member

@gdams gdams commented Aug 17, 2021 •
edited

After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • The commit message includes the cask’s name and version.

@gdams gdams marked this pull request as draft August 17, 2021 10:29
@gdams
Copy link
Member Author

gdams commented Aug 17, 2021

Keeping in draft until I know the strategy for openj9 casks

@drothmaler
Copy link

Shouldn't the deprecation messages reference the closest available temurin version?

At least for the LTS Versions:

  • adoptopenjdk8 --> temurin8
  • adoptopenjdk11 --> temurin11
  • adoptopenjdk17 --> temurin17

For adoptopenjdk13-16 I'd probably recommend temurin17 as the closest LTS Version...

@karianna karianna marked this pull request as ready for review September 25, 2023 02:52
@karianna
Copy link
Member

@gdams LMK if I can help wrap this up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gdams gdams

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gdams @drothmaler @karianna