Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing dev dependencies for eslint-plugin-jsdoc, @typescript-eslint/parser and @typescript-eslint/eslint-plugin #62

Merged

Conversation

Dergash
Copy link
Contributor

@Dergash Dergash commented Jan 24, 2021

While reproducing TypeStrong/typedoc#1480 I've noticed that project didn't launch to me; it seems a couple of dependencies are used in your package.json but are not declared as dependencies and aren't installed during install stage, leading to errors like:

C:\projects\Advanced-Command-Handler>yarn lint
yarn run v1.22.10
$ eslint src/**/*.ts --fix

Oops! Something went wrong! :(

ESLint: 7.18.0

Error: Failed to load parser '@typescript-eslint/parser' declared in 'package.json': Cannot find module '@typescript-eslint/parser'

This PR adds missing dependencies

…nt/parser` and `@typescript-eslint/eslint-plugin`
@Ayfri Ayfri self-requested a review January 24, 2021 02:22
Copy link
Member

@Ayfri Ayfri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I forgot to add these, thanks!

@Ayfri Ayfri merged commit 732cc27 into Advanced-Command-Handler:docs Jan 24, 2021
@Dergash Dergash deleted the fix/missing-dependencies branch January 24, 2021 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants