Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for voting on reviews #304

Draft
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

cmfcmf
Copy link
Member

@cmfcmf cmfcmf commented May 12, 2020

Apparently I worked on this feature some months ago (I just found this branch in my fork) and totally forgot about it.

It allows users to mark reviews of other users as 'helpful' or 'not helpful'. Reviews are sorted intelligently by the helpful/not helpful ratio, similar to how sites like reddit do it.

image

SQL queries to delete the unnecessary rows:

DELETE FROM audit_logs WHERE tbl IN (
  'adventure_list',
  'adventure_list_adventure',
  'change_request',
  'review',
  'review_vote',
  'user',
  'ext_log_entries'
);

DELETE FROM audit_associations WHERE tbl IN (
  'adventure_list',
  'adventure_list_adventure',
  'change_request',
  'review',
  'review_vote',
  'user',
  'ext_log_entries'
);
@Wigginns
Copy link
Collaborator

Wigginns commented May 13, 2020

I like the idea of sorting good reviews to the top but I worry that a “not helpful”/thumbs down option might go the way of reddit up and down votes where people use it to disagree instead of for “does this contribute to the conversation or not”

@cmfcmf
Copy link
Member Author

cmfcmf commented May 13, 2020

You raise a very valid point. Do you have any ideas on how to prevent people from abusing the voting system?

@Wigginns
Copy link
Collaborator

Wigginns commented May 13, 2020

I haven't actually researched this at all, I'm just winging this. It might work to remove the negative option and just let users mark "this review was helpful" or nothing if it wasn't. Maybe my worries are completely unfounded. I'm mostly basing these assumptions off of reddit behavior but maybe with a smaller community it won't be an issue.

@cmfcmf cmfcmf marked this pull request as draft May 25, 2020 08:55
@cmfcmf cmfcmf temporarily deployed to adventurelookup-pr-304 June 21, 2020 07:11 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants