New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layout / Styling Overhaul #394

Draft

cmfcmf wants to merge 2 commits into AdventureLookup:dev from cmfcmf:layout-overhaul

Member

cmfcmf commented Jul 30, 2020 •

edited by gitpod-io bot

This is a work in progress overhaul of our Twig layouts and SCSS styles. Goals include:

The overall appearance of the site should not change dramatically
Less code duplication in Twig layouts and SCSS files
Better semantics: Headers use <h1> instead of <div>, buttons use <button> instead of <div>.
Streamlined, more consistent margins and paddings
A new search bar at the top of most pages (UI: universal search bar needed in site header #159)
Consistent behavior of the header on mobile devices / small screens

TODO:

Extract more things into SCSS variables, review all current SCSS variables
Make more sizes dependent on rem units, ideally set the global font size to 100%.
Remove statistics page code from this PR
Adjust Bootstrap size classes (e.g., pb-2) to use our $layout-gutter values.

Screenshots:

cmfcmf added 2 commits

July 24, 2020 16:08


          Start working on a statistics page

cbd402a


          Overhaul styling

05700fb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment