v6 - Exporting types from root level #2405
Merged
+1,232
−1,173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
size-limit report 📦
|
|
Size Change: +387 B (0%) Total Size: 1.08 MB
ℹ️ View Unchanged
|
ribeiroguilherme
changed the title
ribeiroguilherme
requested review from
marcperez,
pabloai,
sponglord,
m1aw and
longyulongyu
as code owners
|
SonarCloud Quality Gate failed.
|
sponglord
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
{PaymentMethodName}Configuration}.(Ex: CardConfiguration, PayPalConfiguration, ..) So all exposed configs follow same patterntypes.tsfile on the root level (src/types.ts) which exports the typessrc/components/types.tswhich re-export types from the ComponentsCheckoutSessiontypes were moved to CheckoutSessions folder,PaymentMethodsConfigurationtype was moved to Dropin folder, etc.)components/internalfolder . Their types were also moved to their respectivetypes.tsfileBrief explanation of the Types generation pipeline:
tscruns and emit all declarations on/dist/temp-typesfolder . It emits according to the project structure, meaning that we have files spread across different foldersrollup-plugin-tsplugin , which parses the generated files and bundle everything into a single filetemp-typesfolder is deletedUse case:
Tested scenarios
Fixed issue:
#363