v6 Allowing 3DS2 in checkoutshopper demo to work on localhost #2688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sponglord
requested review from
marcperez,
pabloai,
m1aw,
ribeiroguilherme and
longyulongyu
as code owners
|
|
Size Change: +321 B (+0.04%) Total Size: 726 kB
ℹ️ View Unchanged
|
size-limit report 📦
|
|
sponglord
changed the title
packages/lib/src/components/ThreeDS2/components/Challenge/PrepareChallenge3DS2.tsx
Show resolved
Hide resolved
longyulongyu
approved these changes
May 17, 2024
sponglord
deleted the
fix/v6_allowing_checkoutshopper_demo_to_work_on_localhost
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Recent changes in internal data verification within the 3DS2 components mean we don't recognise
http://domains as valid for the related acs/issuer URLs:threeDSMethodURL&acsURL.However the checkoutshopper demo, when run on
localhost:8080generateshttpprotocols for these urlsNot wanting to have to create new config properties for this internal "edge case" - this PR adds an exception to our url validation rule base on the existing
environment, and new,environmentUrlsconfig propertiesTested scenarios
Manual UMD build, tested in checkoutshopper demo, at localhost:8080,