Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5 iDeal becomes a redirect PM #2689

Merged
merged 16 commits into from
May 27, 2024
Merged

Conversation

sponglord
Copy link
Contributor

@sponglord sponglord commented May 16, 2024

Summary

Following instructions from the payment method provider, iDEAL should now be a Redirect rather than IssuerList component

Tested scenarios

Added e2e tests to test the full iDEAL flow, including Redirect result
Refactored existing iDEAL (as issuer list) tests to work with another issuer

Fixed issue: COWEB-1356

Copy link

changeset-bot bot commented May 16, 2024

🦋 Changeset detected

Latest commit: ed8e265

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@adyen/adyen-web Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented May 16, 2024

Size Change: -145 B (-0.01%)

Total Size: 1.15 MB

Filename Size Change
packages/lib/dist/adyen.js 303 kB -42 B (-0.01%)
packages/lib/dist/cjs/index.js 263 kB -43 B (-0.02%)
packages/lib/dist/es.modern/index.js 126 kB -24 B (-0.02%)
packages/lib/dist/es/index.js 146 kB -36 B (-0.02%)
ℹ️ View Unchanged
Filename Size
packages/lib/dist/es.modern/ar.js 6.97 kB
packages/lib/dist/es.modern/cs-CZ.js 6.21 kB
packages/lib/dist/es.modern/da-DK.js 5.62 kB
packages/lib/dist/es.modern/de-DE.js 6.1 kB
packages/lib/dist/es.modern/el-GR.js 7.94 kB
packages/lib/dist/es.modern/es-ES.js 5.75 kB
packages/lib/dist/es.modern/fi-FI.js 5.75 kB
packages/lib/dist/es.modern/fr-FR.js 5.98 kB
packages/lib/dist/es.modern/hr-HR.js 6.01 kB
packages/lib/dist/es.modern/hu-HU.js 6.3 kB
packages/lib/dist/es.modern/it-IT.js 5.83 kB
packages/lib/dist/es.modern/ja-JP.js 6.71 kB
packages/lib/dist/es.modern/ko-KR.js 6.34 kB
packages/lib/dist/es.modern/nl-NL.js 5.78 kB
packages/lib/dist/es.modern/no-NO.js 5.59 kB
packages/lib/dist/es.modern/pl-PL.js 6.28 kB
packages/lib/dist/es.modern/pt-BR.js 5.79 kB
packages/lib/dist/es.modern/pt-PT.js 5.92 kB
packages/lib/dist/es.modern/ro-RO.js 6.07 kB
packages/lib/dist/es.modern/ru-RU.js 7.41 kB
packages/lib/dist/es.modern/sk-SK.js 6.38 kB
packages/lib/dist/es.modern/sl-SI.js 5.92 kB
packages/lib/dist/es.modern/sv-SE.js 5.61 kB
packages/lib/dist/es.modern/zh-CN.js 6.14 kB
packages/lib/dist/es.modern/zh-TW.js 6.23 kB
packages/lib/dist/es/ar.js 6.97 kB
packages/lib/dist/es/cs-CZ.js 6.21 kB
packages/lib/dist/es/da-DK.js 5.62 kB
packages/lib/dist/es/de-DE.js 6.1 kB
packages/lib/dist/es/el-GR.js 7.94 kB
packages/lib/dist/es/es-ES.js 5.75 kB
packages/lib/dist/es/fi-FI.js 5.75 kB
packages/lib/dist/es/fr-FR.js 5.98 kB
packages/lib/dist/es/hr-HR.js 6.01 kB
packages/lib/dist/es/hu-HU.js 6.3 kB
packages/lib/dist/es/it-IT.js 5.83 kB
packages/lib/dist/es/ja-JP.js 6.71 kB
packages/lib/dist/es/ko-KR.js 6.34 kB
packages/lib/dist/es/nl-NL.js 5.78 kB
packages/lib/dist/es/no-NO.js 5.59 kB
packages/lib/dist/es/pl-PL.js 6.28 kB
packages/lib/dist/es/pt-BR.js 5.79 kB
packages/lib/dist/es/pt-PT.js 5.92 kB
packages/lib/dist/es/ro-RO.js 6.07 kB
packages/lib/dist/es/ru-RU.js 7.41 kB
packages/lib/dist/es/sk-SK.js 6.38 kB
packages/lib/dist/es/sl-SI.js 5.92 kB
packages/lib/dist/es/sv-SE.js 5.61 kB
packages/lib/dist/es/zh-CN.js 6.14 kB
packages/lib/dist/es/zh-TW.js 6.23 kB

compressed-size-action

@sponglord sponglord changed the title iDeal becomes a redirect PM v5 iDeal becomes a redirect PM May 16, 2024
@sponglord sponglord closed this May 22, 2024
@sponglord sponglord reopened this May 22, 2024
Copy link

sonarcloud bot commented May 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sponglord sponglord merged commit f4f2b17 into main May 27, 2024
12 checks passed
@sponglord sponglord deleted the feature/v5_iDeal_as_redirect_pm branch May 27, 2024 08:27
@github-actions github-actions bot mentioned this pull request May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants