Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5 GooglePay adds origin to state.data #2690

Merged
merged 1 commit into from
May 17, 2024

Conversation

sponglord
Copy link
Contributor

@sponglord sponglord commented May 16, 2024

Summary

Adding origin to state.data allows Card payments in GooglePay to follow the native 3DS2 checkout flow.
Without this property the /payments request triggers the 3DSInMDFlow (redirect).

NOTE: this issue has already been addressed in v6

Tested Scenarios

Manually tested: Card payment in GooglePay, leads to native 3DS2 challenge

Fixed issue: COWEB-1222, #2681

Copy link

changeset-bot bot commented May 16, 2024

🦋 Changeset detected

Latest commit: f61ef48

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@adyen/adyen-web Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Size Change: +43 B (0%)

Total Size: 1.15 MB

Filename Size Change
packages/lib/dist/adyen.js 303 kB +14 B (0%)
packages/lib/dist/cjs/index.js 263 kB +13 B (0%)
packages/lib/dist/es.modern/index.js 125 kB +4 B (0%)
packages/lib/dist/es/index.js 146 kB +12 B (+0.01%)
ℹ️ View Unchanged
Filename Size
packages/lib/dist/es.modern/ar.js 6.97 kB
packages/lib/dist/es.modern/cs-CZ.js 6.21 kB
packages/lib/dist/es.modern/da-DK.js 5.62 kB
packages/lib/dist/es.modern/de-DE.js 6.1 kB
packages/lib/dist/es.modern/el-GR.js 7.94 kB
packages/lib/dist/es.modern/es-ES.js 5.75 kB
packages/lib/dist/es.modern/fi-FI.js 5.75 kB
packages/lib/dist/es.modern/fr-FR.js 5.98 kB
packages/lib/dist/es.modern/hr-HR.js 6.01 kB
packages/lib/dist/es.modern/hu-HU.js 6.3 kB
packages/lib/dist/es.modern/it-IT.js 5.83 kB
packages/lib/dist/es.modern/ja-JP.js 6.71 kB
packages/lib/dist/es.modern/ko-KR.js 6.34 kB
packages/lib/dist/es.modern/nl-NL.js 5.78 kB
packages/lib/dist/es.modern/no-NO.js 5.59 kB
packages/lib/dist/es.modern/pl-PL.js 6.28 kB
packages/lib/dist/es.modern/pt-BR.js 5.79 kB
packages/lib/dist/es.modern/pt-PT.js 5.92 kB
packages/lib/dist/es.modern/ro-RO.js 6.07 kB
packages/lib/dist/es.modern/ru-RU.js 7.41 kB
packages/lib/dist/es.modern/sk-SK.js 6.38 kB
packages/lib/dist/es.modern/sl-SI.js 5.92 kB
packages/lib/dist/es.modern/sv-SE.js 5.61 kB
packages/lib/dist/es.modern/zh-CN.js 6.14 kB
packages/lib/dist/es.modern/zh-TW.js 6.23 kB
packages/lib/dist/es/ar.js 6.97 kB
packages/lib/dist/es/cs-CZ.js 6.21 kB
packages/lib/dist/es/da-DK.js 5.62 kB
packages/lib/dist/es/de-DE.js 6.1 kB
packages/lib/dist/es/el-GR.js 7.94 kB
packages/lib/dist/es/es-ES.js 5.75 kB
packages/lib/dist/es/fi-FI.js 5.75 kB
packages/lib/dist/es/fr-FR.js 5.98 kB
packages/lib/dist/es/hr-HR.js 6.01 kB
packages/lib/dist/es/hu-HU.js 6.3 kB
packages/lib/dist/es/it-IT.js 5.83 kB
packages/lib/dist/es/ja-JP.js 6.71 kB
packages/lib/dist/es/ko-KR.js 6.34 kB
packages/lib/dist/es/nl-NL.js 5.78 kB
packages/lib/dist/es/no-NO.js 5.59 kB
packages/lib/dist/es/pl-PL.js 6.28 kB
packages/lib/dist/es/pt-BR.js 5.79 kB
packages/lib/dist/es/pt-PT.js 5.92 kB
packages/lib/dist/es/ro-RO.js 6.07 kB
packages/lib/dist/es/ru-RU.js 7.41 kB
packages/lib/dist/es/sk-SK.js 6.38 kB
packages/lib/dist/es/sl-SI.js 5.92 kB
packages/lib/dist/es/sv-SE.js 5.61 kB
packages/lib/dist/es/zh-CN.js 6.14 kB
packages/lib/dist/es/zh-TW.js 6.23 kB

compressed-size-action

Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@sponglord sponglord changed the title GooglePay adds origin to state.data v5 GooglePay adds origin to state.data May 17, 2024
@sponglord sponglord merged commit 37705ce into main May 17, 2024
11 of 12 checks passed
@sponglord sponglord deleted the fix/GooglePay_adds_origin_to_state_data branch May 17, 2024 15:03
@github-actions github-actions bot mentioned this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants