-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update Yarn to v3 (berry) #8461
base: master
Are you sure you want to change the base?
Conversation
Need to fix CI: yarnpkg/berry#2621 |
835ed0c
to
8b61a2f
Compare
5af1c3a
to
cec543f
Compare
dapp tests failing to run
Something in the bowels of SES. Any ideas @kriskowal ? UPDATE: it was the |
Can you clarify?
If we're going through the trouble of upgrading with a breaking change version, have we considered alternative package managers (npm or pnpm)? In general I am concerned about these low level changes that affect the structure of the repo while we have a release branch to maintain. The rebuild of xsnap motivation seems like an issue that should be fixed by our xsnap package, not the package manager used. |
find-replace: ("@agoric/.*":) .*" $1 "workspace:*"
version 7.0+ used in cosmic-swingset already has the fix
Blocked by #8381 |
closes: #451
Description
Version 4 seems close to release (4.0.rc53 is out) but the breaking changes won't affect us much so let's go ahead to v3 now. https://github.com/yarnpkg/berry/blob/master/CHANGELOG.md#master
Security Considerations
n/a. Though does open the option to keep the registry cache in the repo, reducing supply chain risk.
Scaling Considerations
n/a
Documentation Considerations
I haven't noticed anything breaking workflows. If they are it deserves a loud Slack announcement.
Testing Considerations
CI
Upgrade Considerations
n/a