feat: extend makeInteractiveSigner and make it exportable
#54
+42
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adds fifth optional argument `opts` to `makeInteractiveSigner` - allows additional Registry types to be sent in `opts.registryTypes` - allows additonal amino converters to be sent in `opts.converters` - allows initial client gas price to be set with `opts.gasPrice` - exposes `signAndBroadcast` method, that takes any EncodeObject as an argument - exposes `makeInteractiveSigner` externally to consumers
0xpatrickdev
force-pushed
the
pc/make-interactive-signer-export
branch
from
01cced4
to
f0d9525
Compare
0xpatrickdev
added a commit
to 0xpatrickdev/agoric-gov-proposal-hub
that referenced
this pull request
Oct 29, 2023
- uses amino signer in an attempt to successfully submit MsgInstallBundle - still no luck, but Amino has a better UX as messages are human-readble in the Keplr Modal (text instead of binary data) - new issue emerges with Amino Types, it seems the CoreEval proposal is not parsed correctly. an RPC submissions results signature mismatch error: Broadcasting transaction failed with code 4 (codespace: sdk). Log: signature verification failed; - see Agoric/ui-kit#54 for upstream changes to @agoric/web-components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extend makeInteractiveSigner and make it exportable
optstomakeInteractiveSigneropts.registryTypesopts.convertersopts.gasPricesignAndBroadcastmethod, that takes any EncodeObject as an argumentmakeInteractiveSignerexternally to consumers