Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prerequisites.sh #1528

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update prerequisites.sh #1528

wants to merge 2 commits into from

Conversation

basisbit
Copy link
Contributor

Updates bunch of dependencies:

OPENSSL_VERSION=3.0.13
SRTP_VERSION=2.5.0
SRT_VERSION=1.5.3
OPUS_VERSION=1.4
VPX_VERSION=1.14.0
FDKAAC_VERSION=2.0.3
NASM_VERSION=2.16.01
FFMPEG_VERSION=6.1.1
PCRE2_VERSION=10.43

I already did smoke-testing with a sample stream: compiling works, starting as origin works, starting as edge works, rtmp provider works, srt provider works, OVT publisher works, ovt provider works, WebRTC provider works over udp and over tcp, LLHLS provider works, HLS provider works, x264 transcoding works, AAC -> OPUS transcoding works and rtmp push to YouTube still works. So far I didn't find any new issues after applying these changes and rebuilding the docker images.

(These changes don't get Enhanced RTMP to work yet, that will require changes to the OME code for rtmp-push_session initialization, rtmp-export_chunk and also the code which feeds the stream data to ffmpeg.)
cc #1480

@basisbit
Copy link
Contributor Author

The ffmpeg configure options --disable-lzo, --enable-network, --enable-dct and --enable-rdft do not exist any more. The ffmpeg mailing list had an explanation that lzo check now is done through header-checks instead through a config flag, and the other three --enable options were replaced by being enabled by default.

@getroot
Copy link
Sponsor Member

getroot commented Feb 17, 2024

ffmpeg major version upgrades may affect hardware encoders, so take time to check. Is there a need to upgrade ffmpeg major?

@getroot getroot requested a review from Keukhan February 17, 2024 17:43
@basisbit
Copy link
Contributor Author

basisbit commented Feb 17, 2024

ffmpeg 6.1 is needed for Enhanced RTMP, for being able to forward AV1 / HEVC to YouTube. This change is not urgent, it can stay open as a pull request for some time until someone with a intel GPU and someone with NVIDIA GPU did test if hardware accelerated transcoding still works.

@trapasso
Copy link
Contributor

@basisbit ... I'm testing ffmpeg 6, nice work.

I build on ubuntu 20.04 and nasm version 2.16.01 requires autoconf to version 2.71 or greater:
"configure.ac:3: error: Autoconf version 2.71 or higher is required".

With the older version of nasm 2.15.05, it works fine.
Maybe it's better to wait a bit to change the nasm version.

Thank's for your job.

@basisbit
Copy link
Contributor Author

autoconf 2.71 is already 3 years...

@trapasso
Copy link
Contributor

The version of autoconf is 2.69, in the Ubuntu 20.04 repositories.
From here two possibilities: remove support for Ubuntu 20.04 or install it from the prerequisites.
What did you think you were doing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants