Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Close nested popups without closing parent(s) #1033

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vkolova
Copy link

@vkolova vkolova commented Mar 6, 2024

Enable preventing of popup close from closing all parents. This PR aims to resolve #874 .

This is especially useful in the cases where you use the Dropdown component for a "popup window" and you use the same component to implement fancy Select component. You want to be able to use the Select without the whole thing closing.

This PR proposes a new config setting hideParents, which is true by default as to not introduce issues with existing projects.

Copy link

netlify bot commented Mar 6, 2024

Deploy Preview for v-tooltip ready!

Name Link
🔨 Latest commit 8ec0347
🔍 Latest deploy log https://app.netlify.com/sites/v-tooltip/deploys/65e8663fdc7e1b0008b73e66
😎 Deploy Preview https://deploy-preview-1033--v-tooltip.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vkolova
Copy link
Author

vkolova commented Mar 11, 2024

Hi @Akryum I know you're probably busy, but can you take a look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Close nested VDropdown without closing parent programmatically
1 participant