Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Deployment Targets #3717

Merged
merged 3 commits into from May 9, 2023
Merged

Bump Deployment Targets #3717

merged 3 commits into from May 9, 2023

Conversation

jshier
Copy link
Contributor

@jshier jshier commented May 9, 2023

Issue Link πŸ”—

#3716

Goals ⚽

This PR bumps the deployment targets to the iOS 11 generation to fix issues when using Xcode 14.3.

Implementation Details 🚧

Deployment target bumps and removal of relevant conditionals.

@jshier jshier added this pull request to the merge queue May 9, 2023
Merged via the queue into master with commit e065ed9 May 9, 2023
40 checks passed
@jshier jshier deleted the update-deployment-targets branch May 9, 2023 21:32
@jshier jshier added this to the 5.7.0 milestone May 9, 2023
@IAmConorNolan
Copy link

Hey @jshier,

Xcode 15 removes support for iOS 11 in a similar way. Should we expect updated deployment targets following Xcode 15's stable release?

@jshier
Copy link
Contributor Author

jshier commented Aug 22, 2023

No. This PR had to be reverted (#3720) since moving deployment targets is a major breaking change. So far Xcode minimum deployment target changes just produce warnings, which can be avoided or allowed through the various package manager tools. I'll keep an eye out for any breaking changes from Xcode, and feel free to open a new issue if you see one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants