Lazy load picture thumbnails #2693
Draft
+305
−241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A large page can have a lot of picture thumbnails with most of them offscreen. Lazy loading them should speed up the page rendering.
tvdeyen
force-pushed
the
lazy-load-thumbnails
branch
5 times, most recently
from
f0bf010
to
e2875d3
Compare
Use a broken image icon instead of a warning icon, because the image could just be missing. A bit more padding makes it look nicer in the thumbnail background.
Pry is not maintaned anymore. The debug gem some how calls `File.exist?` and we expect that in elements definitions spec. Luckily we can simply remove that, because we only need to stub `File.read` for this spec.
tvdeyen
force-pushed
the
lazy-load-thumbnails
branch
from
e2875d3
to
dfac16b
Compare
tvdeyen
force-pushed
the
main
branch
3 times, most recently
from
4ea5c7d
to
19e4094
Compare
|
This pull request has not seen any activiy in a long time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A large page can have a lot of picture thumbnails with most of them offscreen. Lazy loading them should speed up the page rendering.
What is this pull request for?
Describe you pull request here...
Closes # (Remove if not related to any issue)
Notable changes (remove if none)
Explain any changes (maybe breaking?) that have been made.
Screenshots
Remove if no visual changes have been made.
Checklist